Skip to content

prevent deadlock on close #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
Merged

prevent deadlock on close #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dsqueue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ func (q *DSQueue) GetN(n int) ([][]byte, error) {
if n == 0 {
return nil, nil
}
rsp := make(chan getResponse)
// Buffer response channel so write can happen even if reader gone.
rsp := make(chan getResponse, 1)
req := getRequest{
n: n,
rsp: rsp,
Expand Down
4 changes: 2 additions & 2 deletions dsqueue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ func BenchmarkGetN(b *testing.B) {
queue := dsqueue.New(ds, dsqName, dsqueue.WithDedupCacheSize(0))
defer queue.Close()

cids := random.Cids(25)
cids := random.Cids(64)

b.ResetTimer()
b.ReportAllocs()
Expand All @@ -423,7 +423,7 @@ func BenchmarkGetN(b *testing.B) {
queue.Put(c.Bytes())
}

outItems, err := queue.GetN(50)
outItems, err := queue.GetN(100)
if err != nil {
b.Fatal(err)
}
Expand Down
Loading