fix: fixes cache leak and unhandled promise rejection #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some bugs in the new request cache:
1. When stopping the client we were supposed to remove the response
cache, instead we were deleting an item from the cache
2. When stopping we were `void`ing the cache deletion - this can
cause unhandeled promise rejections so switches to `await`ing
the promise instead
3. When starting the cache was being created asynchronously but without
waiting for the promise to resolve, so you could stop the client
before the cache was intialized which would mean it is never
cleaned up
2color
reviewed
Nov 18, 2024
2color
approved these changes
Nov 18, 2024
|
Btw, are you certain that we call start in consumers of the client (Helia and libp2p)?
|
|
Yes, we call |
|
Also sorry for not getting to the review of #151 in time, this PR is me doing it post-merge. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
## [@helia/delegated-routing-v1-http-api-client-v4.2.1](https://github.com/ipfs/helia-delegated-routing-v1-http-api/compare/@helia/delegated-routing-v1-http-api-client-4.2.0...@helia/delegated-routing-v1-http-api-client-4.2.1) (2024-11-19) ### Bug Fixes * fixes cache leak and unhandled promise rejection ([#152](#152)) ([1c54723](1c54723))
|
🎉 This PR is included in version @helia/delegated-routing-v1-http-api-client-v4.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs in the new request cache:
voiding the cache deletion - this can cause unhandled promise rejections so switches toawaiting the promise insteadAlso not a bug but it also makes the cache name configurable.
Change checklist