Skip to content

feat(routing/http): return 200 for empty results per IPIP-513 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(routing/http): return 200 for empty results per IPIP-513 #174

wants to merge 2 commits into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 11, 2025 •
edited
Loading

Description

Implements IPIP-513 spec changes for delegated routing v1 endpoints to return 200 with empty results instead of 404 + some extra fixes to ensure client interop with broad type of servers.

changes

  • server returns 200 instead of 404 for empty results
    • providers: empty JSON/NDJSON array
    • peers: empty JSON/NDJSON array
    • ipns: text/plain "Record not found"
  • client handles both 200 and 404 responses for backward compatibility
  • client handles null/undefined Providers/Peers fields

test coverage

  • added tests for 404 backward compatibility (old servers)
  • added tests for null/undefined field handling
  • added tests for IPNS content-type validation
  • test fixtures use special CIDs to trigger edge cases

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@lidel
feat: implement IPIP-513 for routing v1 endpoints
7eb3ea2 
changes:
- server returns 200 instead of 404 for empty results
  - providers: empty JSON/NDJSON array
  - peers: empty JSON/NDJSON array
  - ipns: text/plain "Record not found"
- client handles both 200 and 404 responses for backward compatibility
- client handles null/undefined Providers/Peers fields

test coverage:
- added tests for 404 backward compatibility (old servers)
- added tests for null/undefined field handling
- added tests for IPNS content-type validation
- test fixtures use special CIDs to trigger edge cases
@lidel lidel mentioned this pull request Sep 11, 2025
Open
@lidel lidel changed the title feat: implement IPIP-513 (200 instead of 404) feat(routing/http): return 200 for empty results per IPIP-513 Sep 11, 2025
@lidel lidel mentioned this pull request Sep 11, 2025
Closed
@lidel lidel force-pushed the feat/ipip-513-empty-200s branch from 53b7481 to 1459f1d Compare September 11, 2025 05:00
@lidel lidel requested a review from achingbrain September 11, 2025 06:17
@lidel lidel marked this pull request as ready for review September 11, 2025 06:17
@lidel lidel requested a review from a team as a code owner September 11, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't return 404s from routing calls
1 participant
@lidel