-
Notifications
You must be signed in to change notification settings - Fork 890
Integrated aegir as lint #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Integrated aegir as lint #2960
Conversation
removing enableRemoteModule from last mentions in the docs: And figured out how to access a |
Further Updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pfed-prog thank you for opening this, but we can't accept this PR in the current form:
- these
getUserMedia
andBrowserWindow
fixes should be separate PRs. It is time-consuming to review when you have thousands of unrelated lines changed in this PR due to linter.- please remove these changes from this linter PR, and open a new PR per each of them.
- the linter fixes are fine, as long you remove dependency on
aegir
and only depend on linter. (adding 30k of lines topackage-lock.json
just for linter does not feel acceptable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To build on what @lidel said, this PR is quite large and complex, making it challenging to review comprehensively. Your contributions here are extremely valuable and we really want to keep you coming back because we could certainly use the assistance, but let me suggest a few guidelines:
When making sweeping changes like this, it's good to do it gradually, where each PR would:
- fix only a small number of files
- enable linting only for the fixed files so there are no regressions
Feel free to leave this PR open in draft and pull out smaller changes in separate PRs so they can be reviewed more easily.
Makes a lot of sense I do believe that aegir related lint improvements could be discarded But I have created smaller prs based on this large pr |
Following up on #2959