Skip to content

Integrated aegir as lint #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Integrated aegir as lint #2960

wants to merge 15 commits into from

Conversation

Pfed-prog
Copy link

@Pfed-prog Pfed-prog commented Jun 12, 2025

Following up on #2959

@Pfed-prog Pfed-prog requested review from lidel, SgtPooki and a team as code owners June 12, 2025 20:46
@Pfed-prog
Copy link
Author

Fixing error type by wrapping in String()
image

image

@Pfed-prog
Copy link
Author

removing enableRemoteModule from BrowserWindow Electron module

last mentions in the docs:
https://www.electronjs.org/blog/electron-10-0#breaking-changes

Why?
https://www.electronjs.org/docs/latest/breaking-changes#default-changed-enableremotemodule-defaults-to-false

We recommend moving away from the remote module.

And figured out how to access a height and width property by following docs
https://www.electronjs.org/docs/latest/api/structures/display

@Pfed-prog
Copy link
Author

Further Updating getUserMedia
https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
outdated API for getting media streams from the user's device. The mandatory object and properties like chromeMediaSource are specific to older implementations and may not be compatible with modern browsers.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pfed-prog thank you for opening this, but we can't accept this PR in the current form:

  • these getUserMedia and BrowserWindow fixes should be separate PRs. It is time-consuming to review when you have thousands of unrelated lines changed in this PR due to linter.
    • please remove these changes from this linter PR, and open a new PR per each of them.
  • the linter fixes are fine, as long you remove dependency on aegir and only depend on linter. (adding 30k of lines to package-lock.json just for linter does not feel acceptable)

@lidel lidel marked this pull request as draft June 24, 2025 12:12
@Pfed-prog Pfed-prog marked this pull request as ready for review July 1, 2025 14:07
@Pfed-prog Pfed-prog mentioned this pull request Jul 18, 2025
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build on what @lidel said, this PR is quite large and complex, making it challenging to review comprehensively. Your contributions here are extremely valuable and we really want to keep you coming back because we could certainly use the assistance, but let me suggest a few guidelines:

When making sweeping changes like this, it's good to do it gradually, where each PR would:

  1. fix only a small number of files
  2. enable linting only for the fixed files so there are no regressions

Feel free to leave this PR open in draft and pull out smaller changes in separate PRs so they can be reviewed more easily.

@Pfed-prog
Copy link
Author

Makes a lot of sense

I do believe that aegir related lint improvements could be discarded

But I have created smaller prs based on this large pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants