Skip to content

Bump i18next-icu to ^2.4.3 & intl-messageformat ^11.1.2#3051

Open
RubenKelevra wants to merge 5 commits intoipfs:mainfrom
RubenKelevra:pr/i18next-icu-2.4
Open

Bump i18next-icu to ^2.4.3 & intl-messageformat ^11.1.2#3051
RubenKelevra wants to merge 5 commits intoipfs:mainfrom
RubenKelevra:pr/i18next-icu-2.4

Conversation

@RubenKelevra
Copy link
Contributor

This updates i18next-icu to ^2.4.3 and bumps intl-messageformat to ^11.1.2 to match its peer dependency range. This is a follow-up to loading i18next-icu via dynamic import() to support ESM-only releases.

Testing: I can only test on Linux. I tested core functionality under Linux with Electron 39.5.1.

Note: This commit contains the changes of PR #3048, #3049 and #3050, as soon as they are accepted, I'll remove those commits.

v8-compile-cache breaks dynamic import() in this process.
electron-serve is ESM in newer versions, which breaks CommonJS require().

Kick off electron-serve initialization at module load and await it during init so the webui:// scheme is registered before we create windows / load URLs.
Prep for updating i18next-icu: newer versions are ESM-only, so require() breaks.

Dynamic import works with both CommonJS and ESM.
Follow up to the ESM loader change so we can use the newer electron-serve release.
Use newer i18next-icu which requires intl-messageformat >=10.3.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant