Bump i18next-icu to ^2.4.3 & intl-messageformat ^11.1.2#3051
Open
RubenKelevra wants to merge 5 commits intoipfs:mainfrom
Open
Bump i18next-icu to ^2.4.3 & intl-messageformat ^11.1.2#3051RubenKelevra wants to merge 5 commits intoipfs:mainfrom
RubenKelevra wants to merge 5 commits intoipfs:mainfrom
Conversation
This was referenced Feb 9, 2026
Open
This was referenced Feb 11, 2026
v8-compile-cache breaks dynamic import() in this process.
electron-serve is ESM in newer versions, which breaks CommonJS require(). Kick off electron-serve initialization at module load and await it during init so the webui:// scheme is registered before we create windows / load URLs.
Prep for updating i18next-icu: newer versions are ESM-only, so require() breaks. Dynamic import works with both CommonJS and ESM.
Follow up to the ESM loader change so we can use the newer electron-serve release.
Use newer i18next-icu which requires intl-messageformat >=10.3.3.
6bc219a to
1339fe8
Compare
This was referenced Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
i18next-icuto^2.4.3and bumpsintl-messageformatto^11.1.2to match its peer dependency range. This is a follow-up to loading i18next-icu via dynamicimport()to support ESM-only releases.Testing: I can only test on Linux. I tested core functionality under Linux with Electron
39.5.1.Note: This commit contains the changes of PR #3048, #3049 and #3050, as soon as they are accepted, I'll remove those commits.