-
Notifications
You must be signed in to change notification settings - Fork 525
fix: Typescript Migration, localstorage.js bundler to context #2410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@SAHU-01 thanks for your contribution.. However, this local storage file doesn't seem to be an actual redux-bundler bundle. We could probably just move the file as-is to src/lib/local-storage.. no need to use context or context-bridge for this at all as they're just function wrappers for localStorage. |
Thank you for your review @SgtPooki , I'll do the needful and update this PR asap! |
…om/SAHU-01/ipfs-webui into migration/local-storage-to-context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good except some breakage of indentation
Following the REDUX-BUNDLER-MIGRATION-GUIDE.md this PR migrates local-storage.js bundler to fix part of #2349
Changes:
->src/bundles/pinning.js
->src/bundles/gateway.js
->src/bundles/ipns.js
->src/bundles/ipfs-provider.js
Pattern: Replaced import { readSetting, writeSetting } from './local-storage.js' with context bridge selectors using createContextSelector('localStorage').
Testing: App loads without localStorage-related console errors. All localStorage functionality preserved.
Reviewer:
@SgtPooki