Skip to content

Conversation

SAHU-01
Copy link
Contributor

@SAHU-01 SAHU-01 commented Sep 28, 2025

Refactored code for #2349 identicon component typescript migration

Changes

  • Added src/components/identicon/identicon.tsx (functional TSX component using react-identicons)
  • Deleted legacy src/components/identicon/Identicon.js
  • Converted Storybook to TS: identicon.stories.ts with proper Meta/StoryObj typing
  • Added local type defs for lib: src/types/react-identicons.d.ts
  • Updated import in src/components/cid/Cid.js to new path: ../identicon/identicon.js
  • Update tsconfig.json includes for new .tsx/story files

Tests

  • Build: no errors (npm run build passes)
  • Lint: no issues (npm run lint passes)
  • Storybook: toggling identicon renders/hides the identicon correctly in Cid V0 → Identicon stories (size/className controls behave as expected, onClick argument has been removed from stories).

Screenshot/Recording

Screen.Recording.2025-09-28.at.10.14.19.PM.mov
image

Reviewers: @SgtPooki

@SAHU-01 SAHU-01 requested a review from a team as a code owner September 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant