feat: support pin.update #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
I can't think of a better way to get around ipfsd-ctl not using the latest... I'm fine with the tsconfig.json changes.
@achingbrain are we missing anything here?
SgtPooki
requested changes
Jun 9, 2025
Co-authored-by: Russell Dempsey <[email protected]>
One better way would be to put all Kubo related javascript libraries in a monorepo, but I'm not doing that 😅 |
SgtPooki
approved these changes
Jun 19, 2025
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
/pin/updateendpoint, which is useful for updating named pins in particular.While implementing the tests I ran into a circular dependency where
ipfsd-ctlwas using KuboRPCClient, that obviously didn't supportpin.update. Hence thetsconfig.jsonupdate. Let me know if there's a better way around this problem.