fix: SweepingProvider shouldn't error when missing DHT#10975
Merged
Conversation
guillaumemichel
added
the
skip/changelog
when SweepingProvider is enabled but no DHT is available (e.g., Routing.Type=none), the daemon would panic with a nil pointer dereference in ResettableKeystore.ResetCids. this fix: - returns NoopProvider when no DHT implementation is available - skips keystore initialization for NoopProvider to avoid unnecessary operations - allows nodes to run without DHT when using HTTP-only routing or offline mode the panic occurred because initKeyStore tried to access a nil keystore when SweepingProvider returned nil for the keystore parameter. by checking if the provider is NoopProvider and skipping keystore operations, we avoid the panic while maintaining correct behavior for all other provider types. cc #10974 #10975
lidel
reviewed
Sep 19, 2025
lidel
approved these changes
Sep 19, 2025
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
All green, merging for testing in 0.38.0-rc1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Sweeping Provider is enabled, but no DHT is supplied,
SweepingProviderOpt()shouldn't return an error.We want to transition Sweeping Provider to being the default provide mode, and it should be OK for a kubo node not to use a DHT. DHT provides will not happen, but fx shouldn't fail.
IIRC this was included in #10834 but probably overwritten due to conflicts in #10951