Closed
Conversation
`ipfs dag stat -h` says: ``` USAGE ipfs dag stat <root>... - Gets stats for a DAG. ipfs dag stat [--progress=false] [--] <root>... ``` but `--progress` defaults to `true`. So by default it prints this : ``` ipfs dag stat -progress=true QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 95, NumBlocks: 1 CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 202, NumBlocks: 2 CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 8912, NumBlocks: 3 CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 271056, NumBlocks: 4 CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 533200, NumBlocks: 5 ... <actual dag stat summary>. ``` I find this confusing. Is this intended? This PR switches to: ``` ipfs dag stat QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 95, NumBlocks: -1 CID: QmaCxzMg6FZRkDi61q4ymWcCvoj6GkuBo5mVszi5DHBpb1, Size: 107, NumBlocks: -1 CID: QmUf2ynPG2wCJe3zLaASNJrQKN3BkboD2VRAKcwteDAUQB, Size: 8710, NumBlocks: -1 CID: bafkreibspggfqizukzodgaivbqusjz2xugesiaf3cutlf5rayzkfawhyry, Size: 262144, NumBlocks: -1 CID: bafkreicagz2co2ryds5auotj5kgwbqt7mvfzua4o54fv24rbycodytnmuu, Size: 262144, NumBlocks: -1 ... <actual summary> ``` which means it lists the nodes that are traversed as it makes progress traversing the DAG.
gammazero
reviewed
Sep 26, 2025
Comment on lines
+55
to
+59
| curDagstats := &DagStat{ | ||
| Cid: current.Node.Cid(), | ||
| Size: currentNodeSize, | ||
| NumBlocks: -1, | ||
| } |
Contributor
There was a problem hiding this comment.
If curDagstate is only used inside the if progressive { block, then can this code be moved into there?
Member
|
Triage notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipfs dag stat -hsays:but
--progressdefaults totrue.So by default it prints this :
I find this confusing. Is this intended? This PR switches to:
which means it lists the nodes that are traversed as it makes progress traversing the DAG.