[skip changelog] Optimize dag stat with DP caching #11088
+155
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tat` to avoid redundant traversals when multiple DAGs share common subgraphs. Resolves TODO in `core/commands/dag/stat.go:17-18`: > "cache every cid traversal in a dp cache. if the cid exists in the cache, don't traverse it, and use the cached result to compute the new state" - **Added `cidStatCache`** structure to memoize subtree statistics for each CID - **Replaced linear traversal** with recursive DP algorithm that: - Checks cache before traversing any node - Skips entire subtree traversal for cached CIDs - Computes and caches subtree stats (size + block count) for each node - **Maintains correct accounting** for TotalSize, SharedSize, and deduplication ratios - Added `TestDagStatCaching` with two test cases: - Cache consistency when querying duplicate CIDs - Correct deduplication stats with shared subgraph Signed-off-by: sneax <[email protected]>
Contributor
|
Triage: Will review. This may be useful for pinner and for dag import, possibly by caching different data. Review should assess additional use cases. |
gammazero
added
P1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements dynamic programming cache for CID traversal in
ipfs dag statto avoid redundant traversals when multiple DAGs share common subgraphs.Resolves TODO in
core/commands/dag/stat.go:17-18Changes
Core Implementation
cidStatCachestructure to memoize subtree statistics for each CIDTesting
TestDagStatCachingwith two test cases:Performance Impact
Time Complexity: