Merged
Conversation
adds RAINBOW_DIAGNOSTIC_SERVICE_URL configuration option to expose boxo/gateway's DiagnosticServiceURL setting. when gateway returns 504 timeout, users will see "Inspect retrievability of CID" button linking to diagnostic service with CID as query parameter. defaults to https://check.ipfs.network, can be disabled by setting to empty string. related to ipshipyard/roadmaps#14
Member
Author
|
Pebble bump makes this a bigger change. Will switch to v1.20 |
0386c93 to
fe1aad0
Compare
|
Suggested version: Changes in configuration file(s): diff --git a/go.mod b/go.mod
index a477d1e..1cbe5fc 100644
--- a/go.mod
+++ b/go.mod
@@ -4,7 +4,7 @@ go 1.24.0
require (
contrib.go.opencensus.io/exporter/prometheus v0.4.2
- github.com/cockroachdb/pebble v1.1.4
+ github.com/cockroachdb/pebble/v2 v2.1.0
github.com/coreos/go-systemd/v22 v22.5.0
github.com/dgraph-io/badger/v4 v4.5.1
github.com/dustin/go-humanize v1.0.1
@@ -18,7 +18,7 @@ require (
github.com/ipfs/go-ds-badger4 v0.1.8
github.com/ipfs/go-ds-flatfs v0.5.5
github.com/ipfs/go-ds-leveldb v0.5.2
- github.com/ipfs/go-ds-pebble v0.4.4
+ github.com/ipfs/go-ds-pebble v0.5.3
github.com/ipfs/go-log/v2 v2.8.1
github.com/ipfs/go-metrics-interface v0.3.0
github.com/ipfs/go-metrics-prometheus v0.1.0
@@ -52,19 +52,21 @@ require (
)
require (
- github.com/DataDog/zstd v1.5.6-0.20230824185856-869dae002e5e // indirect
+ github.com/DataDog/zstd v1.5.7 // indirect
github.com/Jorropo/jsync v1.0.1 // indirect
+ github.com/RaduBerinde/axisds v0.0.0-20250419182453-5135a0650657 // indirect
+ github.com/RaduBerinde/btreemap v0.0.0-20250419174037-3d62b7205d54 // indirect
github.com/alecthomas/units v0.0.0-20240927000941-0f3dac36c52b // indirect
github.com/alexbrainman/goissue34681 v0.0.0-20191006012335-3fc7a47baff5 // indirect
github.com/benbjohnson/clock v1.3.5 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/cenkalti/backoff/v5 v5.0.3 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
- github.com/cockroachdb/datadriven v1.0.3-0.20240530155848-7682d40af056 // indirect
+ github.com/cockroachdb/crlib v0.0.0-20241112164430-1264a2edc35b // indirect
github.com/cockroachdb/errors v1.11.3 // indirect
- github.com/cockroachdb/fifo v0.0.0-20240606204812-0bbfbd93a7ce // indirect
github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b // indirect
github.com/cockroachdb/redact v1.1.5 // indirect
+ github.com/cockroachdb/swiss v0.0.0-20250624142022-d6e517c1d961 // indirect
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.5 // indirect
github.com/crackcomm/go-gitignore v0.0.0-20241020182519-7843d2ba8fdf // indirect
@@ -133,6 +135,7 @@ require (
github.com/miekg/dns v1.1.68 // indirect
github.com/mikioh/tcpinfo v0.0.0-20190314235526-30a79bb1804b // indirect
github.com/mikioh/tcpopt v0.0.0-20190314235656-172688c1accc // indirect
+ github.com/minio/minlz v1.0.1-0.20250507153514-87eb42fe8882 // indirect
github.com/minio/sha256-simd v1.0.1 // indirect
github.com/multiformats/go-base32 v0.1.0 // indirect
github.com/multiformats/go-base36 v0.2.0 // indirect
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds Check CID retrievability button to HTTP 504 error pages:
It adds
--diagnostic-service-urlconfiguration option to allow overriding the default service URL (https://check.ipfs.network)Why?
My bad, I missed the fact that by default
DiagnosticServiceURLis not set.I'm going to ship this as v1.19.1 and then open PR in waterworks-infra to disable nginx
proxy_intercept_errorsso we can see these modern error pages.