Skip to content

Conversation

@afbase
Copy link

@afbase afbase commented May 15, 2025

relates to #197

@afbase
Copy link
Author

afbase commented May 15, 2025

I think we're very close. I'm not sure how to best go about the lint issue and if maintainers can get this over the hump, that would be greatly appreciated.

@afbase
Copy link
Author

afbase commented May 15, 2025

cc: @vmx

@afbase
Copy link
Author

afbase commented May 15, 2025

the main issue is this dependency_on_unit_never_type_fallback.

quote! {
#[allow(dependency_on_unit_never_type_fallback)]
#encode
#[allow(dependency_on_unit_never_type_fallback)]
#decode

I'm not sure how you feel about it but the idea above I think would pass all tests if we modify dag-cbor-derive/src/lib.rs

@afbase
Copy link
Author

afbase commented May 15, 2025

see #202

the main issue is this dependency_on_unit_never_type_fallback.

quote! {
#[allow(dependency_on_unit_never_type_fallback)]
#encode
#[allow(dependency_on_unit_never_type_fallback)]
#decode

I'm not sure how you feel about it but the idea above I think would pass all tests if we modify dag-cbor-derive/src/lib.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant