Conversation
Underscores in topology.name are used by clab to generate hostnames, and some Linux distros don't grasp that a clumsy person might have underscores in hostnames. This fix ensures there are no weird characters in topology.name that is generated from the input directory (and 'default' is used when nothing is left after the cleanup). We don't check what the user specifies in the 'name' argument (they should know better ;) Fixes #2424
DanPartelly
approved these changes
Jul 7, 2025
Collaborator
DanPartelly
left a comment
DanPartelly
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Underscores in topology.name are used by clab to generate hostnames, and some Linux distros don't grasp that a clumsy person might have underscores in hostnames.
This fix ensures there are no weird characters in topology.name that is generated from the input directory (and 'default' is used when nothing is left after the cleanup). We don't check what the user specifies in the 'name' argument (they should know better ;)
Fixes #2424