Skip to content

Allow setting "no switchport" on link agregations on cisco l2 images.#2504

Merged
ipspace merged 1 commit intodevfrom
ios_2499
Jul 8, 2025
Merged

Allow setting "no switchport" on link agregations on cisco l2 images.#2504
ipspace merged 1 commit intodevfrom
ios_2499

Conversation

@DanPartelly
Copy link
Collaborator

Allow setting port channels interfaces as "no switchport". Keep current logic for everything else.

@DanPartelly DanPartelly requested a review from ipspace July 8, 2025 15:15
Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (and the initial configuration test works on IOSv, so the Jinja2 syntax is OK); the real test will come when you add the LAG code to IOS.

@ipspace ipspace merged commit e27d05d into dev Jul 8, 2025
@ipspace ipspace deleted the ios_2499 branch July 8, 2025 15:19
@DanPartelly
Copy link
Collaborator Author

DanPartelly commented Jul 8, 2025

It will work. I do not feed untested changes to you, or if it's a device major feature arc without integration tests run. Problem is, I'm used with low level strong(er) typed languages with no run-time reflection, so most of the time Ill forget of ... is defined ... or run time type checking (so you guys will get un-tastefull things) complemented by zome wrong assumptions about data sometimes. Your tips on how to check it helped, but It will take a while to become habit. Im getting better at Python and Jinja , but I cant say I like either of them, yet. But you know what the chefs say: Palatability often comes with habit.

Looks good to me (and the initial configuration test works on IOSv, so the Jinja2 syntax is OK); the real test will come when you add the LAG code to IOS.

@ipspace
Copy link
Owner

ipspace commented Jul 9, 2025

It will work. I do not feed untested changes to you, or if it's a device major feature arc without integration tests run.

👍

Problem is, I'm used with low level strong(er) typed languages with no run-time reflection

Yeah, I feel your pain. I started with Pascal, and the "everything goes" approach of JavaScript or Python is (trying to be extra-diplomatic) suboptimal. But hey, it is what it is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants