Fix: run on-push actions in pull requests from third-party repos#2505
Merged
Fix: run on-push actions in pull requests from third-party repos#2505
Conversation
The 'on-push' GH actions are not executed (within the context of main netlab repo) if the pull request comes from another repository, so we don't know whether they would pass. This change brings mypy and transformation tests back to the 'on-pull' workflow, but hopefully executes them only if the source repo is not 'ipspace/netlab'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'on-push' GH actions are not executed (within the context of main netlab repo) if the pull request comes from another repository, so we don't know whether they would pass.
This change brings mypy and transformation tests back to the 'on-pull' workflow, but hopefully executes them only if the source repo is not 'ipspace/netlab'