Set containerlab version in installation configuration#2514
Merged
Conversation
The containerlab installation script expects the CONTAINERLAB_VERSION environment variable to contain the target clab version. We had to modify the installation script each time we wanted to change the version; this commit introduces an alternative mechanism and bumps the containerlab version to 0.68.0: * The environment variables depending on system defaults are specified in the install.yml configuration file * CONTAINERLAB_VERSION environment variable depends on clab.version value (now set to 0.68.0) * The 'netlab install' command sets the environment variables specified in the install.yml configuration file before starting the scripts Collateral fix: * 'netlab install' recognized the 'dry-run' flag but did not pass it to 'external_commands' module. Fixes #2498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The containerlab installation script expects the CONTAINERLAB_VERSION environment variable to contain the target clab version. We had to modify the installation script each time we wanted to change the version; this commit introduces an alternative mechanism and bumps the containerlab version to 0.68.0:
Collateral fix:
Fixes #2498