Skip to content

BGP confederations on Dell OS10, EOS, FRR, and IOS#2520

Merged
ipspace merged 3 commits intodevfrom
bgp-confed
Jul 10, 2025
Merged

BGP confederations on Dell OS10, EOS, FRR, and IOS#2520
ipspace merged 3 commits intodevfrom
bgp-confed

Conversation

@ipspace
Copy link
Owner

@ipspace ipspace commented Jul 9, 2025

Based on work done by @jbemmel in #2426

@ipspace ipspace requested a review from jbemmel July 9, 2025 18:43
@ipspace
Copy link
Owner Author

ipspace commented Jul 9, 2025

IOS configuration template is broken, fix coming tomorrow... All BGP integration test pass for EOS, FRR, OS10

ipspace added a commit that referenced this pull request Jul 9, 2025
advertise_loopback: true
as: 65001
community:
confed_ebgp:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could limit the community types to those being used in the topology, and avoid all these changes

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, someone might want to limit the spread of extended communities to member autonomous systems. Also, the changes to test results don't hurt if we know why they happen.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... however, it's trivial to enable "confed_ebgp" value only when the topology uses confederations, so why not 😎

Copy link
Collaborator

@jbemmel jbemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes more sense than a separate plugin

Minor tweak possible to limit changes to YAML files for stuff not being used anyway - but it will work either way

ipspace added a commit that referenced this pull request Jul 10, 2025
@ipspace ipspace merged commit a5d794b into dev Jul 10, 2025
11 checks passed
@ipspace ipspace deleted the bgp-confed branch July 10, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants