BGP confederations on Dell OS10, EOS, FRR, and IOS#2520
Conversation
|
IOS configuration template is broken, fix coming tomorrow... All BGP integration test pass for EOS, FRR, OS10 |
tests/topology/expected/6pe.yml
Outdated
| advertise_loopback: true | ||
| as: 65001 | ||
| community: | ||
| confed_ebgp: |
There was a problem hiding this comment.
Could limit the community types to those being used in the topology, and avoid all these changes
There was a problem hiding this comment.
In theory, someone might want to limit the spread of extended communities to member autonomous systems. Also, the changes to test results don't hurt if we know why they happen.
There was a problem hiding this comment.
... however, it's trivial to enable "confed_ebgp" value only when the topology uses confederations, so why not 😎
jbemmel
left a comment
There was a problem hiding this comment.
I think this makes more sense than a separate plugin
Minor tweak possible to limit changes to YAML files for stuff not being used anyway - but it will work either way
Based on work done by @jbemmel in #2426