Use shared warnings and wait times in ripv2 and routing tests#2536
Merged
Use shared warnings and wait times in ripv2 and routing tests#2536
Conversation
ipspace
added a commit
that referenced
this pull request
Jul 12, 2025
jbemmel
reviewed
Jul 12, 2025
| ping: 5 | ||
| ping_long: 15 | ||
| vxlan_ping: 20 | ||
| ping_xx_long: 40 # Needed in some VRF scenarios due to crazily slow control plane |
Collaborator
There was a problem hiding this comment.
Not referenced in this PR?
Owner
Author
There was a problem hiding this comment.
Not referenced in this PR?
Nope, needed for the next PR (but I was doing multiple changes in parallel with running integration tests)
jbemmel
approved these changes
Jul 12, 2025
Collaborator
jbemmel
left a comment
jbemmel
left a comment
There was a problem hiding this comment.
Assuming the extra long ping will be used elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.