Conversation
Owner
Author
ipspace
added a commit
that referenced
this pull request
Aug 3, 2025
ssasso
approved these changes
Aug 4, 2025
Collaborator
ssasso
left a comment
ssasso
left a comment
There was a problem hiding this comment.
great work thanks!!!!
I will slowly adapt all the other templates
VyOS configuration templates are vbash scripts that include a lot of setup and cleanup code. The same code is replicated in every template. That is not good by itself, but it doesn't allow the users to use simple custom config templates with just the 'set' commands. This change implements configuration deployment similar to what we're doing for FRR: if the configuration code includes 'vbash', it's executed as-is, otherwise it's wrapped in a standard vbash script. Also changed: * The 'are we ready' check has been moved from the 'deploy config' task list to 'readyness check' task list * The 'fetch config' task list fetches device configuration as 'set' commands, allowing it to be used directly as a custom config template. That should allow 'netlab up --reload' to work with VyOS. * BGP and IS-IS templates have been cleaned up as a proof-of-concept
ipspace
added a commit
that referenced
this pull request
Oct 21, 2025
Similar to #2572, this change generates warnings whenever L3VPN AF is enabled on BGP sessions that do not propagate extended communities.
ipspace
added a commit
that referenced
this pull request
Oct 21, 2025
Similar to #2572, this change generates warnings whenever L3VPN AF is enabled on BGP sessions that do not propagate extended communities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VyOS configuration templates are vbash scripts that include a lot of
setup and cleanup code. The same code is replicated in every template.
That is not good by itself, but it doesn't allow the users to use
simple custom config templates with just the 'set' commands.
This change implements configuration deployment similar to what
we're doing for FRR: if the configuration code includes 'vbash',
it's executed as-is, otherwise it's wrapped in a standard vbash
script.
Also changed:
task list to 'readyness check' task list
'set' commands, allowing it to be used directly as a custom config
template. That should allow 'netlab up --reload' to work with
VyOS.