Skip to content

Use 'files' plugin to implement inline configuration templates#2580

Merged
ipspace merged 2 commits intodevfrom
config-inline
Aug 8, 2025
Merged

Use 'files' plugin to implement inline configuration templates#2580
ipspace merged 2 commits intodevfrom
config-inline

Conversation

@ipspace
Copy link
Owner

@ipspace ipspace commented Aug 8, 2025

This change adds support for inline custom configuration templates in node-, group- and validation test definitions. It allows the user to specify small additions to device configurations directly in the node- or group definition, or to define small changes to device configurations directly in the validation tests.

This change adds support for inline custom configuration templates in
node-, group- and validation test definitions. It allows the user to
specify small additions to device configurations directly in the node-
or group definition, or to define small changes to device configurations
directly in the validation tests.
@ipspace
Copy link
Owner Author

ipspace commented Aug 8, 2025

The final step of the configlets journey: specifying custom configurations directly in node/group/test definitions.

I will update the node/group/validate documentation once we're OK with attribute naming ;)

@ipspace ipspace requested a review from jbemmel August 8, 2025 11:20
Copy link
Collaborator

@jbemmel jbemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find it less than intuitive that, as a user, I need to include the 'files' plugin to get access to a 'config.inline' sub-element under validation

Perhaps loading the 'files' plugin by default, or otherwise making it part of standard functionality would be better.

The code is ok and the feature is great, it's just about helping users figure things out easily

@jbemmel
Copy link
Collaborator

jbemmel commented Aug 8, 2025

I still find it less than intuitive that, as a user, I need to include the 'files' plugin to get access to a 'config.inline' sub-element under validation

Perhaps loading the 'files' plugin by default, or otherwise making it part of standard functionality would be better.

The code is ok and the feature is great, it's just about helping users figure things out easily

I just saw #2579 so I know you were aware of this - my point is about finding a way to avoid having to go through this error in the first place

@ipspace
Copy link
Owner Author

ipspace commented Aug 8, 2025

The code is ok and the feature is great, it's just about helping users figure things out easily

I don't have a rock-solid reason, but as the "files and friends" functionality vastly expands the capabilities of overwriting something, I have a funny feeling that making this part of standard functionality would be giving out too much rope.

@ipspace ipspace merged commit 1719cd0 into dev Aug 8, 2025
4 checks passed
@ipspace ipspace deleted the config-inline branch August 8, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants