A router with localas_ibgp session MUST change NH on all IBGP routes#2591
Merged
A router with localas_ibgp session MUST change NH on all IBGP routes#2591
Conversation
The routes received over localas_ibgp session have to be reflected to other IBGP neighbors. The next hop on those reflected routes MUST be changed because we're not advertising the inter-AS subnet into IGP. That makes the router with localas_ibgp session unsuitable to be a RR. This change adds an extra step after the IBGP and EBGP sessions have been built. It checks for the presence of localas_ibgp session and sets neighbor.next_hop_self to 'all' on all IBGP sessions if needed.
Owner
Author
|
The (hopefully) final step of a very long journey started by #1996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The routes received over localas_ibgp session have to be reflected to other IBGP neighbors. The next hop on those reflected routes MUST be changed because we're not advertising the inter-AS subnet into IGP.
That makes the router with localas_ibgp session unsuitable to be a RR.
This change adds an extra step after the IBGP and EBGP sessions have been built. It checks for the presence of localas_ibgp session and sets neighbor.next_hop_self to 'all' on all IBGP sessions if needed.