Skip to content

Commit 87b05c6

Browse files
jcb91consideRatio
authored andcommitted
[init_cell] PR code review corrections
1 parent a31dccd commit 87b05c6

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ Unreleased (aka. GitHub master)
2121
This is where each new PR to the project should add a summary of its changes,
2222
which makes it much easier to fill in each release's changelog :)
2323

24+
- Added CONTRIBUTING.md
25+
[#1224](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1224)
26+
[@consideratio](https://github.com/consideratio)
2427

2528
0.4.0
2629
-----
@@ -47,9 +50,6 @@ Repo-level stuff:
4750
[#1200](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1200),
4851
[#1201](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1201)
4952
[@jcb91](https://github.com/jcb91)
50-
- Added CONTRIBUTION.md
51-
[#1224](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1224)
52-
[@consideratio](https://github.com/consideratio)
5353

5454
New features and bugfixes:
5555

CONTRIBUTING.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Contributing to jupyter notebook nbextensions
22

3-
We are super happy that you intend to contribute to the nbextensions! You can discuss improvements in issues and improvement them in pull requests.
3+
We are super happy that you intend to contribute to the nbextensions! You can discuss improvements in issues and implement them in pull requests.
44

55
## Create an issue
66

@@ -22,7 +22,9 @@ cd jupyter_contrib_nbextensions
2222
```shell
2323
# run from the main directory, where setup.py is
2424
pip install --editable .
25-
jupyter-contrib-nbextension install --symlink --sys-prefix
25+
26+
# on windows, remove the --symlink flag and run the command in between changes
27+
jupyter-contrib-nbextension install --sys-prefix --symlink
2628
```
2729

2830
## Create an extension

MANIFEST.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# explicit includes
22
include COPYING.rst
33
include README.md
4+
include CONTRIBUTING.md
45
include CHANGELOG.md
56
include tox.ini
67
include .bumpversion.cfg

0 commit comments

Comments
 (0)