Skip to content

Commit b1c2555

Browse files
committed
Fix case table when no var has shape
Turns out I did need has_shape
1 parent 9bfe025 commit b1c2555

File tree

1 file changed

+3
-1
lines changed
  • src/jupyter_contrib_nbextensions/nbextensions/varInspector

1 file changed

+3
-1
lines changed

src/jupyter_contrib_nbextensions/nbextensions/varInspector/main.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,17 @@ function html_table(jsonVars) {
130130
var varList = JSON.parse(String(jsonVars))
131131

132132
var shape_str = '';
133+
var has_shape = false;
133134
if (varList.some(listVar => "varShape" in listVar && listVar.varShape !== '')) { //if any of them have a shape
134135
shape_str = '<th >Shape</th>';
136+
has_shape = true;
135137
}
136138
var beg_table = '<div class=\"inspector\"><table class=\"table fixed table-condensed table-nonfluid \"><col /> \
137139
<col /><col /><thead><tr><th >X</th><th >Name</th><th >Type</th><th >Size</th>' + shape_str + '<th >Value</th></tr></thead><tr><td> \
138140
</td></tr>';
139141
varList.forEach(listVar => {
140142
var shape_col_str = '';
141-
if ('varShape' in listVar) {
143+
if (has_shape) {
142144
shape_col_str = '</td><td>' + listVar.varShape + '</td><td>';
143145
}
144146
beg_table +=

0 commit comments

Comments
 (0)