Don't show %guiref in banner #101
Conversation
We're getting rid of the %guiref magic - see spyder-ide/qtconsole#98
See ipython/ipykernel#101 This will break compatibility with ipykernel releases before that PR is merged, so milestoning for 5.0.
| from IPython.core.magic import magics_class, line_magic, Magics | ||
| from IPython.core import payloadpage | ||
| from IPython.core.usage import default_gui_banner | ||
| from IPython.core.usage import default_banner |
There was a problem hiding this comment.
I'd prefer that we could do the removal of default_gui_banner in the next minor IPython release instead of the next major one (given that's such a small change).
So I propose to enclose this in a try/except block, like this:
try:
from IPython.core.usage import default_gui_banner as default_banner
except ImportError:
from IPython.core.usage import default_bannerThere was a problem hiding this comment.
The try/except is not necessary, because default_banner was already defined. The issue is that the IPython release that removes default_gui_banner will break compatibility with any ipykernel releases before this PR is merged, including at least ipykernel 4.2.2, the current release. So I don't think we should backport that change to a 4.x release.
Why would it be a problem to have a couple of unused variables sitting in IPython, anyway?
There was a problem hiding this comment.
Sorry, I was thinking that a new release of ipykernel would be hold until IPython 5.0 is ready.
But you're right, default_banner is present in previous IPython releases, so there's no problem with this change :-)
See ipython/ipykernel#101 This will break compatibility with ipykernel releases before that PR is merged, so milestoning for 5.0.
3 participants
We're getting rid of the %guiref magic - see spyder-ide/qtconsole#98