deprecate find_connection_file #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
changed the title
Member
Author
|
Hang on, we use it a little bit internally, but only within the module. A few more deprecations to add... |
it's unused, and the one in jupyter_client should be used instead. It will only be called if `profile` is given when searching for connection files, which is never the right thing to do because connection files live in Jupyter paths now.
minrk
force-pushed
the
deprecate-find-connection-file
branch
from
6f0a117 to
7492c3c
Compare
minrk
changed the title
minrk
changed the title
Member
Author
|
Okay, should be set. |
Member
|
👍 don't forget to update the changelog. |
takluyver
added a commit
that referenced
this pull request
Feb 25, 2016
deprecate find_connection_file
Member
Author
|
Updated in #106 |
minrk
added a commit
that referenced
this pull request
Feb 25, 2016
It's unused, and the one in jupyter_client should be used instead. The only case where it might be used is searching for connection files by profile, which no longer makes sense since connection files aren't stored in IPython profiles. closes #103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unused, and the one in jupyter_client should be used instead.
The only case where it might be used is searching for connection files by profile, which no longer makes sense since connection files aren't stored in IPython profiles.
closes #103