Skip to content

Conversation

@SylvainCorlay
Copy link
Member

No description provided.

@SylvainCorlay
Copy link
Member Author

cc @aburgm

@takluyver
Copy link
Member

@minrk do the shimmed .append() etc. methods on config work to add to default values, or only to previously loaded values? If it's not easy to modify the default, maybe we should leave this non-configurable and add an extra attribute for config to add links.

@SylvainCorlay
Copy link
Member Author

@takluyver when you generate the profile, the default values get added to the config file, so it is easy to modify.

@minrk
Copy link
Member

minrk commented Apr 7, 2016

Yup, append adds to the default. We've also done extra_foo configurables for clearly defining additional items, rather than modifying the existing list. I could go either way. Whether we want people to be able to replace the defaults should probably determine whether we add config=True to the existing trait vs a dedicated extra_help_links trait for more user-defined links.

@SylvainCorlay
Copy link
Member Author

Yup, append adds to the default. We've also done extra_foo configurables for clearly defining additional items, rather than modifying the existing list. I could go either way. Whether we want people to be able to replace the defaults should probably determine whether we add config=True to the existing trait vs a dedicated extra_help_links trait for more user-defined links.

Do we want to force users to keep the current list of links?

@SylvainCorlay
Copy link
Member Author

Do we want to force users to keep the current list of links?

A possible usecase is the one of someone who does not want to use external links...

@takluyver
Copy link
Member

OK, so long as it's easy to add to the defaults, I'm fine with doing it like this.

@minrk
Copy link
Member

minrk commented Apr 7, 2016

Do we want to force the current list of links to users?

That's the question! I don't feel the need to force these links to be always-on, so I'm fine with this PR as-is.

@minrk minrk added this to the 4.4 milestone Apr 7, 2016
@minrk minrk merged commit 3ff596a into ipython:master Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants