Context manager / display hook #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
pinging @jasongrout |
Member
|
@dwillmer, thanks for all of your work on this. I'll go ahead and take it from here. |
| from .displayhook import ZMQMessageHook | ||
|
|
||
|
|
||
| class MessageHookFor(object): |
Member
There was a problem hiding this comment.
For context managers that are typically treated as functions, I think it's more conventional to use function_style_name rather than ObjectStyleName, even though it's technically a type.
Member
|
@jasongrout does your switch to doing this in the frontend mean this PR should be closed? |
Member
|
Probably. I'm working out the details today, and then will close the outdated PRs. |
Member
|
Cool, thanks. |
Member
|
@jasongrout what's the state of these? I'd like to do a 4.4 release soon, but I don't want to make a release with this work half-done. |
Member
|
@minrk - I'm closing this PR since we worked out how to do it nicely from the frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.