Store display outputs in history for %notebook magic
#1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darshan808
force-pushed
the
fix-display-history
branch
from
00846af to
8dc02a8
Compare
|
Would it make sense to bump the IPython version to >9.1.0 (where |
|
I think a conditional block (could be conditional on version) would be preferred, especially because it would be great to backport to 6.x branch. |
krassowski
reviewed
Sep 29, 2025
|
Kicking CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1433
Summary
Fixes issue where display outputs (plots) were not included when using
%notebookmagic to save session as .ipynb file.Changes
ZMQDisplayPublisher.publish()to store display data inhistory_manager.outputs