Skip to content

Fix linting errors #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 2 commits into from
Nov 26, 2025
Merged

Fix linting errors #1480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
463cf84
Fix linting errors
ianthomas23 Nov 26, 2025
43197e7
Iterate
ianthomas23 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ipykernel/zmqshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def edit(self, parameter_s="", last_call=None):

payload = {"source": "edit_magic", "filename": filename, "line_number": lineno}
assert self.shell is not None
self.shell.payload_manager.write_payload(payload) # type: ignore[unreachable]
self.shell.payload_manager.write_payload(payload) # type: ignore[union-attr]

# A few magics that are adapted to the specifics of using pexpect and a
# remote terminal
Expand All @@ -361,7 +361,7 @@ def edit(self, parameter_s="", last_call=None):
def clear(self, arg_s):
"""Clear the terminal."""
assert self.shell is not None
if os.name == "posix": # type: ignore[unreachable]
if os.name == "posix":
self.shell.system("clear")
else:
self.shell.system("cls")
Expand All @@ -383,7 +383,7 @@ def less(self, arg_s):

if arg_s.endswith(".py"):
assert self.shell is not None
cont = self.shell.pycolorize(openpy.read_py_file(arg_s, skip_encoding_cookie=False)) # type: ignore[unreachable]
cont = self.shell.pycolorize(openpy.read_py_file(arg_s, skip_encoding_cookie=False))
else:
with open(arg_s) as fid:
cont = fid.read()
Expand All @@ -398,7 +398,7 @@ def less(self, arg_s):
def man(self, arg_s):
"""Find the man page for the given command and display in pager."""
assert self.shell is not None
page.page(self.shell.getoutput("man %s | col -b" % arg_s, split=False)) # type: ignore[unreachable]
page.page(self.shell.getoutput("man %s | col -b" % arg_s, split=False))

@line_magic
def connect_info(self, arg_s):
Expand Down