Avoid creating default connection dir if not needed #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The test failure looks like there is another case where the directory needs to be created. |
If a connection file is specified with an absolute path via the '-f' command line option, ipykernel still makes sure that the default connection directory exists, even though it is not needed. Instead, simply create the directory for the path to the connection file that we end up actually using. This introduces a slight change in behaviour in that if one specifies a connection file via the '-f' option and the given directory does not exist, it will be created instead of an error being generated.
Author
|
Indeed... I updated the commit so it creates the directory already during initialization, instead of when the file is actually written. |
minrk
added a commit
that referenced
this pull request
Aug 20, 2015
Avoid creating default connection dir if not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a connection file is specified with an absolute path via the '-f'
command line option, ipykernel still makes sure that the default connection
directory exists, even though it is not needed. Instead, simply create the
directory for the path to the connection file that we end up actually
using.
This introduces a slight change in behaviour in that if one specifies a
connection file via the '-f' option and the given directory does not
exist, it will be created instead of an error being generated.
In my case, I am specifying a different path to the connection file because the default path is not writable. While I could (and probably should) change the default path with the corresponding environment variables, it still left me wondering whether the default connection directory should be created even if it is not going to be used.