BF: Stop searching when a port is found/bound #429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edisongustavo
approved these changes
Sep 11, 2019
Contributor
edisongustavo
left a comment
edisongustavo
left a comment
There was a problem hiding this comment.
The change makes a lot of sense to me.
(I can't merge because I'm not a contributor though).
Contributor
|
LGTM, too, having just encountered this in another project. The test failure on Appveyor doesn't appear to be related. |
Contributor
Author
|
I'd ignore this PR, and favour #431 instead, as it adds a regression test in addition to fixing the bug. |
Contributor
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (what I think is) a trivial bug in
ipykernel/heartbeat.py.This loop in the
Heartbeat,_bind_socketmethod should be broken as soon as an available port number is found.