Skip to content

Fixes typo in InstallIPythonKernelSpecApp #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Carreau merged 2 commits into from
Sep 22, 2015
Merged

Fixes typo in InstallIPythonKernelSpecApp #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7455715
add test to ensure that kernelspec installs
mpacer Sep 22, 2015
64d2a11
fixed variable name typo `dispay` to `display`
mpacer Sep 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ipykernel/kernelspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def start(self):
opts = parser.parse_args(self.argv)
try:
dest = install(user=opts.user, kernel_name=opts.name, prefix=opts.prefix,
dispay_name=opts.display_name,
display_name=opts.display_name,
)
except OSError as e:
if e.errno == errno.EACCES:
Expand Down
14 changes: 13 additions & 1 deletion ipykernel/tests/test_kernelspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import shutil
import sys
import tempfile

try:
from unittest import mock
except ImportError:
Expand All @@ -20,6 +20,7 @@
get_kernel_dict,
write_kernel_spec,
install,
InstallIPythonKernelSpecApp,
KERNEL_NAME,
RESOURCES,
)
Expand Down Expand Up @@ -75,6 +76,17 @@ def test_write_kernel_spec_path():
shutil.rmtree(path)


def test_install_kernelspec():

path = tempfile.mkdtemp()
try:
test = InstallIPythonKernelSpecApp.launch_instance(argv=['--prefix', path])
assert_is_spec(os.path.join(
path, 'share', 'jupyter', 'kernels', KERNEL_NAME))
finally:
shutil.rmtree(path)


def test_install_user():
tmp = tempfile.mkdtemp()

Expand Down