Skip to content

remove more nose #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 1 commit into from
Aug 17, 2021
Merged

remove more nose #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions ipykernel/tests/test_kernelspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,18 @@

import pytest

import nose.tools as nt

pjoin = os.path.join


def test_make_ipkernel_cmd():
cmd = make_ipkernel_cmd()
nt.assert_equal(cmd, [
assert cmd == [
sys.executable,
'-m',
'ipykernel_launcher',
'-f',
'{connection_file}'
])
]


def assert_kernel_dict(d):
Expand All @@ -51,10 +49,9 @@ def test_get_kernel_dict():


def assert_kernel_dict_with_profile(d):
nt.assert_equal(d['argv'], make_ipkernel_cmd(
extra_arguments=["--profile", "test"]))
assert d['display_name'] == 'Python %i (ipykernel)' % sys.version_info[0]
assert d['language'] == 'python'
assert d["argv"] == make_ipkernel_cmd(extra_arguments=["--profile", "test"])
assert d["display_name"] == "Python %i (ipykernel)" % sys.version_info[0]
assert d["language"] == "python"


def test_get_kernel_dict_with_profile():
Expand Down Expand Up @@ -127,7 +124,7 @@ def test_install_profile():
with open(spec) as f:
spec = json.load(f)
assert spec["display_name"].endswith(" [profile=Test]")
nt.assert_equal(spec["argv"][-2:], ["--profile", "Test"])
assert spec["argv"][-2:] == ["--profile", "Test"]


def test_install_display_name_overrides_profile():
Expand Down