Skip to content

Do not call setQuitOnLastWindowClosed() on a QCoreApplication #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 1 commit into from
Oct 25, 2021
Merged

Do not call setQuitOnLastWindowClosed() on a QCoreApplication #791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ipykernel/eventloops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,11 @@ def loop_qt4(kernel):
"""Start a kernel with PyQt4 event loop integration."""

from IPython.lib.guisupport import get_app_qt4
from IPython.external.qt_for_kernel import QtGui

kernel.app = get_app_qt4([" "])
kernel.app.setQuitOnLastWindowClosed(False)
if isinstance(kernel.app, QtGui.QApplication):
kernel.app.setQuitOnLastWindowClosed(False)
_notify_stream_qt(kernel, kernel.shell_stream)

_loop_qt(kernel.app)
Expand Down