Skip to content

IPython's start_kernel is deprecated. #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 1 commit into from
Dec 9, 2021
Merged

IPython's start_kernel is deprecated. #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions ipykernel/tests/test_start_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
from .test_embed_kernel import setup_kernel
from flaky import flaky
from textwrap import dedent

TIMEOUT = 15


@flaky(max_runs=3)
def test_ipython_start_kernel_userns():
cmd = ('from IPython import start_kernel\n'
'ns = {"tre": 123}\n'
'start_kernel(user_ns=ns)')
cmd = dedent(
"""
from ipykernel.kernelapp import launch_new_instance
ns = {"tre": 123}
launch_new_instance(user_ns=ns)
"""
)

with setup_kernel(cmd) as client:
client.inspect("tre")
Expand All @@ -34,8 +39,12 @@ def test_ipython_start_kernel_userns():
@flaky(max_runs=3)
def test_ipython_start_kernel_no_userns():
# Issue #4188 - user_ns should be passed to shell as None, not {}
cmd = ('from IPython import start_kernel\n'
'start_kernel()')
cmd = dedent(
"""
from ipykernel.kernelapp import launch_new_instance
launch_new_instance()
"""
)

with setup_kernel(cmd) as client:
# user_module should not be an instance of DummyMod
Expand Down