Use signed int to handle getopt_long correctly#15
Merged
iraikov merged 1 commit intoiraikov:masterfrom Aug 15, 2025
Merged
Conversation
Unlike on x86, `char` can be unsigned by default on ARM systems. So when `getopt_long()` returns -1 for indicating end of options, the `char c = -1` can end up as 255. This fix addresses the problem by changing the dtype to int which is always signed int on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike on x86,
charcan be unsigned by default on ARM systems like TACC Vista. So whengetopt_long()returns -1 for indicating end of options, thechar c = -1can end up as 255. This fix addresses the problem by changing the dtype to int which is always signed int on all platforms.