Skip to content

Conversation

@ValwareIRC
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 4, 2025 20:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds additional declared stable capabilities for the ObsidianIRC client in the sw_clients.yml data file. Expands the capabilities list with multiple IRCv3 (and related) features.

  • Adds numerous capability keys (e.g., account-notify, batch, chathistory, multiline, standard-replies)
  • Extends the stable capability set for the client in YAML metadata

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +713 to +734
cap-notify:
account-notify:
account-tag:
account-registration:
away-notify:
batch:
bot-mode:
channel-rename:
chathistory:
echo-message:
extended-join:
message-redaction:
message-tags:
msgid:
multiline:
multi-prefix:
react-client-tag:
sasl-3.1:
server-time:
setname:
standard-replies:
userhost-in-names:
Copy link

Copilot AI Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The newly added capability entries are not in a consistent ordering (e.g., multi-prefix appears after multiline, and related capability types are not grouped), which makes future diffs harder to review. Consider alphabetizing the block or following an established grouping convention; for example: account-notify, account-registration, account-tag, away-notify, batch, bot-mode, cap-notify, channel-rename, chathistory, echo-message, extended-join, message-redaction, message-tags, msgid, multi-prefix, multiline, react-client-tag, sasl-3.1, server-time, setname, standard-replies, userhost-in-names.

Copilot uses AI. Check for mistakes.
@jwheare jwheare merged commit 0fddf26 into ircv3:master Oct 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants