[Support] Add portable float16 and bfloat16 types for Windows #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
changed the title
…bility Add float16 and bfloat16 struct implementations in support/float_types.h that use int16_t storage and perform arithmetic in float32. These provide Windows compatibility where compiler extensions (_Float16, __bf16) are not available. On non-Windows platforms, the compiler extensions are still used. Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Rob Suderman <[email protected]>
…rsions Use std::bit_cast for constexpr support, remove ambiguous int16_t constructor (use fromBits() instead), and use implicit conversions to/from float to avoid operator ambiguity. Remove member binary operators since arithmetic works through float conversion. Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Rob Suderman <[email protected]>
Signed-off-by: Rob Suderman <[email protected]>
Signed-off-by: Rob Suderman <[email protected]>
Signed-off-by: Rob Suderman <[email protected]>
Signed-off-by: Rob Suderman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add float16 and bfloat16 struct implementations in support/float_types.h that use int16_t storage and perform arithmetic in float32. These provide Windows compatibility where compiler extensions (_Float16, __bf16) are not available. On non-Windows platforms, the compiler extensions are still used.