Skip to content

Revert "[NFC] Add error propagation to ASM emitter boundary methods"#289

Open
sjain-stanford wants to merge 1 commit intomainfrom
revert-262-users/MaheshRavishankar/errorPropagationEmitter
Open

Revert "[NFC] Add error propagation to ASM emitter boundary methods"#289
sjain-stanford wants to merge 1 commit intomainfrom
revert-262-users/MaheshRavishankar/errorPropagationEmitter

Conversation

@sjain-stanford
Copy link
Copy Markdown
Member

Reverts #262

(context)

This breaks the assumption that the asm emitter methods never error (if they do that's a failure on the graph validation logic and needs an update). I'd like to better understand the situation that spawned this and see if there's another way to address the underlying issue (why not use debug builds for dev work)? Can you share the repro / error message and what change triggered it?

Usually if these asserts are hit (shouldn't in release builds as that code is unreachable) it is highly likely that something is off in a fresh development branch, which ideally uses debug builds. This change is also very non-uniform - doesn't hold to rest of asm emitters, so I push to revert and then revisit if there's a hidden need I'm not seeing rn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant