Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Rob Suderman <rob.suderman@gmail.com>
| execute(handle, DataType::Int32, int(-128)); | ||
| execute(handle, DataType::Int32, int(128)); |
There was a problem hiding this comment.
Changes the Int32 test input from int(-128) to int(128). This is necessary because log(-128) is undefined, but since every PR branches from main independently, this change only exists in the LOG PR. When merged, this affects all other unary ops' test coverage.
This is fine for LOG (and EXP, ERF, FLOOR which are well-defined for 128), but consider: previously the negative input value -128 provided useful coverage for ABS and NEG. After this change, ABS is only tested with positive input (abs(128) == 128, a no-op) and the benefit of the negative test case is lost.
Suggestion: Rather than changing the shared input, add a second Int32 test case or use a GENERATE on input values, so both positive and negative inputs are exercised.
2 participants
No description provided.