[DO NOT REVIEW] Generalize mlir ukernel with python preprocessing #23275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR generalizes MLIR ukernel generation by introducing a Python preprocessing approach to reduce code duplication and improve maintainability.
Motivation
Before: We currently have 7 hand-written MLIR ukernels, totaling ~3k lines of repetitive code with significant boilerplate:
iree_uk_amdgpu_dt_matmul_f16.mliriree_uk_amdgpu_dt_matmul_f8E4M3FNUZ.mliriree_uk_amdgpu_dt_scaled_matmul_f4E2M1FN.mliriree_uk_amdgpu_matmul_bf16.mliriree_uk_amdgpu_matmul_f16.mliriree_uk_amdgpu_matmul_f8E4M3FN.mliriree_uk_amdgpu_matmul_f8E4M3FNUZ.mlirEach ukernel variant required manual duplication with minor parameter changes (element types, intrinsics, unroll configurations, etc.).
After: This PR introduces a template-based generation system where we only need to maintain some template files (
.mlir.in, around 1k lines at the moment).See
TEMPLATE_GUIDE.mdfor all generation commands.Plan
Assisted-by: Cursor AI