Add C API support for --iree-codegen-tuning-spec-path flag #23320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtianliu
requested review from
MaheshRavishankar,
Max191,
benvanik,
hanhanW and
qedawkins
as code owners
bangtianliu
force-pushed
the
tuning-spec-path-to-c-api
branch
8 times, most recently
from
09cb181 to
2e856f9
Compare
bangtianliu
changed the title
bangtianliu
force-pushed
the
tuning-spec-path-to-c-api
branch
2 times, most recently
from
495a0c5 to
34e24d7
Compare
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
force-pushed
the
tuning-spec-path-to-c-api
branch
from
34e24d7 to
8db6cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
--iree-codegen-tuning-spec-pathflag into a structuredTuningSpecOptionsclass to enable C API access viaireeCompilerSessionSetFlags(). Previously, this flag was defined as a standalonellvm::cl::opt<>which prevented C API users from setting tuning specs programmatically.I have only added C API support for
--iree-codegen-tuning-spec-path. I can extend the same support toiree-codegen-enable-default-tuning-specsandiree-codegen-dump-tuning-specs-toif needed.