[StableHLO] Disable ReorderElementwiseAndShapeOP pattern for iree-stablehlo-to-iree-input #23321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stablehlo-to-iree-input The ReorderElementwiseAndShapeOP pattern is not compatible with the rewriter used in iree-stablehlo-to-iree-input. Added test showcasing that and disabled the pattern in iree-stablehlo-to-iree-input. Signed-off-by: Eryk Szpotanski <[email protected]>
eszpotanski
requested review from
MaheshRavishankar and
rsuderman
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReorderElementwiseAndShapeOPpattern is not compatible with the rewriter used by iree-stablehlo-to-iree-input pass - as some modifications are applied immediately and others (e.g.replaceAllUsesWith) are delayed, it produces invalid state resulting with errors like:This PR adds a test showcasing this error and disables the
ReorderElementwiseAndShapeOPpattern for the iree-stablehlo-to-iree-input pass.