Optionally perform invocation under global lock #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may help with potentially racy behavior of the driver when we attempt to parallelize tests. Signed-off-by: Alex Zinenko <[email protected]>
Hardcode84
reviewed
Dec 29, 2025
| for handler in self.debug_handlers or []: | ||
| handler(debug_logs) | ||
|
|
||
| def invoke(self, *args, **kwargs) -> None: |
Contributor
There was a problem hiding this comment.
As invoke is on a hot path, I would prefer not to complicate default impl too much, better approach may be to monkey patch it in conftest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help with potentially racy behavior of the driver when we attempt to parallelize tests.
** DO NOT MERGE **