fix: using DynamicResource for IconButtonInnerSpacing.#886
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Semi theme’s IconButtonInnerSpacing so icon button templates can pick up spacing via resource lookup (intended to be overridable at runtime/theme-variant time).
Changes:
- Replaces the hardcoded
IconButtonInnerSpacingvalue with a resource alias (SemiSpacingTight) in the shared theme dictionary. - Switches icon button template spacing bindings from
StaticResourcetoDynamicResource. - Changes
BaseIconButtonthemeTargetType(appears unrelated to the PR title and impacts theme inheritance).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Ursa.Themes.Semi/Themes/Shared/IconButton.axaml | Redefines IconButtonInnerSpacing to reference a theme spacing token (SemiSpacingTight). |
| src/Ursa.Themes.Semi/Controls/IconDropDownButton.axaml | Updates spacing bindings to use DynamicResource IconButtonInnerSpacing. |
| src/Ursa.Themes.Semi/Controls/IconButton.axaml | Updates spacing binding to DynamicResource and changes BaseIconButton TargetType, affecting theme inheritance. |
rabbitism
approved these changes
Feb 11, 2026
zdpcdt
added a commit
that referenced
this pull request
Feb 12, 2026
(cherry picked from commit 42ad3b8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.