Skip to content

Conversation

deathcap
Copy link

@deathcap deathcap commented Feb 9, 2015

The Node 'request' module allows options.uri to be a parsed object
from the 'url' module. In this case, the href property is set to
the original URL. Check for this property to restore compatibility
with browser-request/request.

e.g., this code works in node:

require('request')({uri: require('url').parse('http://npmjs.org/')}, function() {})

and now works with a browserified browser-request. Includes test case

The Node 'request' module allows options.uri to be a parsed object
from the 'url' module. In this case, the href property is set to
the original URL. Check for this property to restore compatibility
with browser-request/request.
deathcap added a commit to deathcap/webnpm that referenced this pull request Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant