Merge pull request #2 from irobot-ros/mauro/humble-gcc-8

Set spinning to false in ~EventsExecutor

Author: jefferyyjhsu

irobot_events_executor/include/rclcpp/executors/events_executor/events_executor.hpp

@@ -62,9 +62,9 @@ class EventsExecutor : public rclcpp::Executor
     bool execute_timers_separate_thread = false,
     const rclcpp::ExecutorOptions & options = rclcpp::ExecutorOptions());
 
-  /// Default destrcutor.
+  /// Default destructor.
   RCLCPP_PUBLIC
-  virtual ~EventsExecutor() = default;
+  virtual ~EventsExecutor();
 
   /// Events executor implementation of spin.
   /**

irobot_events_executor/src/rclcpp/executors/events_executor/events_executor.cpp

@@ -50,6 +50,11 @@ EventsExecutor::EventsExecutor(
   entities_collector_->add_waitable(executor_notifier_);
 }
 
+EventsExecutor::~EventsExecutor()
+{
+  spinning.store(false);
+};
+
 void
 EventsExecutor::spin()
 {