Apply fixes required for Clang to compile

Author: apojomovsky

rclcpp/include/rclcpp/client.hpp

@@ -12,6 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// This file has been copied and modified by iRobot.
+// Copyright 2022 iRobot Corporation. All Rights Reserved.
+
 #ifndef RCLCPP__CLIENT_HPP_
 #define RCLCPP__CLIENT_HPP_
 
@@ -863,7 +866,7 @@ class Client : public ClientBase
         // the server might be available in another process or was configured to not use IPC.
         if (intra_process_server_available) {
           // Send intra-process request
-          ipm->send_intra_process_client_request<ServiceT>(
+          ipm->template send_intra_process_client_request<ServiceT>(
             intra_process_client_id_,
             std::make_pair(std::move(request), std::move(value)));
           return ipc_sequence_number_++;

rclcpp/include/rclcpp/experimental/intra_process_manager.hpp

@@ -12,6 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// This file has been copied and modified by iRobot.
+// Copyright 2024 iRobot Corporation. All Rights Reserved.
+
 #ifndef RCLCPP__EXPERIMENTAL__INTRA_PROCESS_MANAGER_HPP_
 #define RCLCPP__EXPERIMENTAL__INTRA_PROCESS_MANAGER_HPP_
 
@@ -405,7 +408,7 @@ class IntraProcessManager
         "Intra-process service gone out of scope. "
         "Do inter-process requests.\n"
         "Client service name: " + std::string(cli->get_service_name());
-      RCLCPP_WARN(rclcpp::get_logger("rclcpp"), warning_msg.c_str());
+      RCLCPP_WARN(rclcpp::get_logger("rclcpp"), "%s", warning_msg.c_str());
       return;
     }
     auto service_intra_process_base = service_it->second.lock();
@@ -771,7 +774,7 @@ class IntraProcessManager
   {
     add_owned_msg_to_buffers<MessageT, Alloc, Deleter, ROSMessageType>(
       std::move(message), {subscription_id}, allocator);
-  }  
+  }
 
   /// Return true if the given rmw_gid_t matches any stored Publishers.
   RCLCPP_PUBLIC

rclcpp_action/include/rclcpp_action/client.hpp

@@ -12,6 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// This file has been copied and modified by iRobot.
+// Copyright 2024 iRobot Corporation. All Rights Reserved.
+
 #ifndef RCLCPP_ACTION__CLIENT_HPP_
 #define RCLCPP_ACTION__CLIENT_HPP_
 
@@ -515,7 +518,7 @@ class Client : public ClientBase
       // If there's not, we fall back into inter-process communication, since
       // the server might be available in another process or was configured to not use IPC.
       if (intra_process_server_available) {
-        ipm->intra_process_action_send_goal_request<ActionT>(
+        ipm->template intra_process_action_send_goal_request<ActionT>(
           ipc_action_client_id_,
           std::move(goal_request),
           callback);
@@ -828,7 +831,7 @@ class Client : public ClientBase
         // If there's not, we fall back into inter-process communication, since
         // the server might be available in another process or was configured to not use IPC.
         if (intra_process_server_available) {
-          ipm->intra_process_action_send_result_request<ActionT>(
+          ipm->template intra_process_action_send_result_request<ActionT>(
             ipc_action_client_id_,
             std::move(goal_result_request),
             callback);
@@ -884,7 +887,7 @@ class Client : public ClientBase
       // If there's not, we fall back into inter-process communication, since
       // the server might be available in another process or was configured to not use IPC.
       if (intra_process_server_available) {
-        ipm->intra_process_action_send_cancel_request<ActionT>(
+        ipm->template intra_process_action_send_cancel_request<ActionT>(
           ipc_action_client_id_,
           std::move(cancel_request),
           callback);

rclcpp_action/include/rclcpp_action/server.hpp

@@ -12,6 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// This file has been copied and modified by iRobot.
+// Copyright 2024 iRobot Corporation. All Rights Reserved.
+
 #ifndef RCLCPP_ACTION__SERVER_HPP_
 #define RCLCPP_ACTION__SERVER_HPP_
 
@@ -528,7 +531,7 @@ class Server : public ServerBase, public std::enable_shared_from_this<Server<Act
       intra_process_action_client_id,
       std::hash<GoalUUID>()(uuid));
 
-    ipm->intra_process_action_send_goal_response<ActionT>(
+    ipm->template intra_process_action_send_goal_response<ActionT>(
       intra_process_action_client_id,
       std::move(goal_response));
 
@@ -597,7 +600,7 @@ class Server : public ServerBase, public std::enable_shared_from_this<Server<Act
         std::move(status_msg));
     }
 
-    ipm->intra_process_action_send_cancel_response<ActionT>(
+    ipm->template intra_process_action_send_cancel_response<ActionT>(
       intra_process_action_client_id,
       std::move(response));
   }
@@ -632,7 +635,7 @@ class Server : public ServerBase, public std::enable_shared_from_this<Server<Act
       }
 
       auto typed_response = std::static_pointer_cast<ResultResponse>(result_response);
-      ipm->intra_process_action_send_result_response<ActionT>(
+      ipm->template intra_process_action_send_result_response<ActionT>(
         intra_process_action_client_id,
         std::move(typed_response));
     }