Skip to content

Unset gc's callback on ~EventsExecutorNotifyWaitable() #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: galactic-events-executor
Choose a base branch
from
Open

Unset gc's callback on ~EventsExecutorNotifyWaitable() #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion rclcpp/include/rclcpp/executors/events_executor_notify_waitable.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ class EventsExecutorNotifyWaitable final : public EventWaitable

// Destructor
RCLCPP_PUBLIC
virtual ~EventsExecutorNotifyWaitable() = default;
virtual ~EventsExecutorNotifyWaitable()
{
for (auto & gc : notify_guard_conditions_) {
gc->set_on_trigger_callback(nullptr);
}
}

// The function is a no-op, since we only care of waking up the executor
RCLCPP_PUBLIC
Expand Down